[FreeRDP] Pass CMake flag BUILD_TESTING and use a target for building fuzzers #10448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
|
No idea if it is going to help, but have you tried with lto disabled? |
@MarcoFalke seems it helps! thanks! |
It is required because some modules enables testing only with this flag.
MSan triggers on OpenSSL function:
```
Uninitialized bytes in __interceptor_fopen64 at offset 0 inside [0x7020000178c0, 25)
==182==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0xe59129 in BIO_new_file (/tmp/not-out/tmpl27pqwad/TestFuzzCommonAssistanceParseFileBuffer+0xe59129)
#1 0xfbd25d in def_load conf_def.o
#2 0xe69a9c in CONF_modules_load_file (/tmp/not-out/tmpl27pqwad/TestFuzzCommonAssistanceParseFileBuffer+0xe69a9c)
#3 0xf50bdf in openssl_config_int (/tmp/not-out/tmpl27pqwad/TestFuzzCommonAssistanceParseFileBuffer+0xf50bdf)
#4 0xeb00f3 in ossl_init_config_ossl_ init.o
```
According to an issue [1] it is a false positive, MemorySanitizer
requires fully instrumented builds to be able to use the it. Disable
MemorySanitizer for now.
1. openssl/openssl#11013
|
@jonathanmetzman could you review, please? |
|
Do you have to disable MSAN? |
Right. Due to false positive in OpenSSL. |
|
@jonathanmetzman is there a policy to squash commits on merge? All my commit messages with exlanations/descriptions were lost :( |
|
Sorry about that. I don't think we do, and to be honest, I don't think we pay a whole lot of attention to what goes in the messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR FreeRDP/FreeRDP#9019