Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving toml coverage #10183

Merged
merged 1 commit into from
May 19, 2023
Merged

Improving toml coverage #10183

merged 1 commit into from
May 19, 2023

Conversation

sg3-141-592
Copy link
Contributor

@sg3-141-592 sg3-141-592 commented Apr 27, 2023 •
edited
Loading

These are some additional improvements to the toml encoder.

  • Remove unneeded fuzzers fuzz_loads and fuzz_dumps. These can both be reached by the fuzz_load and fuzz_dump methods
  • Cover additional encoders TomlOrderedEncoder & TomlNumpyEncoder
  • Cover additional decoders TomlOrderedDecoder & TomlPreserveCommentDecoder
  • Use the dictgen library approach, the same as Adding dumps and doc creation coverage for tomlkit #10046

Using local runs this gives us a coverage of an extra 8 methods.

@sg3-141-592 sg3-141-592 force-pushed the toml-coverage-improvements branch from 616bd69 to 94eb75e Compare April 27, 2023 19:35
@sg3-141-592 sg3-141-592 marked this pull request as ready for review April 27, 2023 19:42
@sg3-141-592 sg3-141-592 marked this pull request as draft April 29, 2023 16:53
@sg3-141-592 sg3-141-592 marked this pull request as ready for review May 4, 2023 07:10
@DonggeLiu DonggeLiu merged commit ea4a6fc into google:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonggeLiu DonggeLiu DonggeLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sg3-141-592 @DonggeLiu