Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanmetzman committed May 15, 2020
1 parent bfdf6b8 commit b1318d9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions infra/cifuzz/fuzz_target.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def is_reproducible(self, test_case, target_path):
Returns:
(True, True) if crash is reproducible and we were able to run the
binary.
(True, False) if we were not able to attempt reproduction. Do not rely
(False, False) if we were not able to attempt reproduction. Do not rely
on the first return value in this case.
(False, True) if we were able to attempt reproduction but the crash did
not reproduce.
Expand Down Expand Up @@ -255,7 +255,7 @@ def is_crash_reportable(self, test_case):

if not ran_target:
# This happens if the project has OSS-Fuzz builds, but the fuzz target
# doesn't.
# is not in it.
logging.info(could_not_test_on_oss_fuzz_message)
return True

Expand Down
4 changes: 2 additions & 2 deletions infra/cifuzz/fuzz_target_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
EXECUTE_FAILURE_RETVAL = ('', '', 1)


# TODO(metzman): Use patch from clusterfuzz/src/python/tests/test_libs/
# so that we don't need to accept this as an argument in every test method.
# TODO(metzman): Use patch from test_libs/helpers.py in clusterfuzz so that we
# don't need to accept this as an argument in every test method.
@unittest.mock.patch('utils.get_container_name', return_value='container')
class IsReproducibleUnitTest(fake_filesystem_unittest.TestCase):
"""Test is_reproducible function in the fuzz_target module."""
Expand Down

0 comments on commit b1318d9

Please sign in to comment.