Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IEC61937 for API 34 #1758

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Add IEC61937 for API 34 #1758

merged 3 commits into from
Apr 7, 2023

Conversation

robertwu1
Copy link
Collaborator

Fixes #1757

@robertwu1 robertwu1 requested review from flamme and philburk March 21, 2023 23:12
@robertwu1 robertwu1 requested a review from flamme March 21, 2023 23:39
flamme
flamme approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@flamme flamme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me. Thanks for making the change!

@philburk
Copy link
Collaborator

philburk commented Apr 4, 2023

Can this be tested?

@robertwu1
Copy link
Collaborator Author

Can this be tested?

You can test opening the stream with OboeTester.

By looking at the device report, if encoding 13 is supported, then this should open for API 34+.

@philburk
Copy link
Collaborator

philburk commented Apr 5, 2023

You can test using OboeTester by selecting IEC61937
then select SampleRate=32000
then select SRC Quality::Medium
Oboe should fail on Open.

@robertwu1
Copy link
Collaborator Author

You can test using OboeTester by selecting IEC61937 then select SampleRate=32000 then select SRC Quality::Medium Oboe should fail on Open.

Good test! This works for SampleRate=32000 but fails for SampleRate=96000 on the TV I tested as 32000 is supported on the TV but not 96000.

@robertwu1 robertwu1 merged commit 8ac53b8 into main Apr 7, 2023
@robertwu1 robertwu1 deleted the robertwu/addiec61937 branch April 7, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk left review comments

@flamme flamme flamme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IEC61937 to Oboe for API 34
3 participants
@robertwu1 @philburk @flamme