Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppCompat and other changes needed for google3 build #2017

Closed
philburk opened this issue May 8, 2024 · 1 comment
Closed

AppCompat and other changes needed for google3 build #2017

philburk opened this issue May 8, 2024 · 1 comment
Assignees
@philburk

Comments

@philburk
Copy link
Collaborator

philburk commented May 8, 2024

Various build errors were discussed here:
b/337360630 | P1 | Remove libOpenSLES DT_NEEDED entry from oboe

MicrophoneInfo code needs SDK 28.
Error: Field requires API level 28 (current min is 23): android.media.MicrophoneInfo.Coordinate

And a bigger task, com/mobileer/audio_device/AudioDeviceSpinner.java needs to use AppCompatSpinner.
This was attempted in #1769
But it broke the menus, #1795
So it was reverted, #1796
@philburk philburk self-assigned this May 8, 2024
philburk added a commit that referenced this issue May 8, 2024
@philburk
Oboetester: use TargetApi(28) for Mic Info
8cda931 
Prevent Linter errors in google3

Also prevent crash on API 25 emulator

For #2017
@philburk philburk mentioned this issue May 8, 2024
Merged
philburk added a commit that referenced this issue May 8, 2024
@philburk
OboeTester: use AppCompatSpinner and AppCompatActivity
a51def9 
For #2017
@philburk philburk mentioned this issue May 8, 2024
Merged
philburk added a commit that referenced this issue May 8, 2024
@philburk
Oboetester: use TargetApi(28) for Mic Info (#2018)
edd0499 
Prevent Linter errors in google3

Also prevent crash on API 25 emulator

For #2017
philburk added a commit that referenced this issue May 9, 2024
@philburk
OboeTester: use AppCompatSpinner and AppCompatActivity (#2019)
ae1134a 
For #2017
@robertwu1
Copy link
Collaborator

google3 has successfully updated Oboe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philburk @robertwu1