Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resampler has very low output when converting from 11025 to 88200 #1625

Closed
philburk opened this issue Sep 14, 2022 · 2 comments · Fixed by #1813
Closed

Resampler has very low output when converting from 11025 to 88200 #1625

philburk opened this issue Sep 14, 2022 · 2 comments · Fixed by #1813
Assignees
@philburk
Labels
bug P0 very high priority

Comments

@philburk
Copy link
Collaborator

Enable the unit test in testResampler.cpp to reproduce this.

There is an initial hump and then the output is shaped correctly but with very low amplitude.
@philburk philburk added the bug label Sep 14, 2022
@philburk philburk self-assigned this Sep 14, 2022
@robertwu1
Copy link
Collaborator

What about 88200 to 11025?

@philburk philburk mentioned this issue Dec 14, 2022
Closed
@philburk philburk added the P1 high priority label May 25, 2023
@philburk
Copy link
Collaborator Author

What about 88200 to 11025?

That seems OK.

These also fail:
11025 => 96000
8000 => 64000
It seems to fail if (outputRate / inputRate >= 4.0)

@philburk philburk added P0 very high priority and removed P1 high priority labels May 26, 2023
philburk added a commit that referenced this issue May 27, 2023
@philburk
resampler: do not filter when upsampling
dfef606 
The sound was muffled when upsampling for no reason.

Fixes #1673
Fixes #1625
@philburk philburk mentioned this issue May 27, 2023
Merged
philburk added a commit that referenced this issue May 31, 2023
@philburk
resampler: do not filter when upsampling (#1813)
f4410aa 
The sound was muffled when upsampling for no reason.

Fixes #1673
Fixes #1625

Enable broken resampler test.
It should work now.

Document that cutoff is ignored when upsampling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
bug P0 very high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resampler: do not filter when upsampling google/oboe
2 participants
@philburk @robertwu1