Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glitches in audio when SRate is 11025 and SRC Best is selected #1622

Closed
philburk opened this issue Sep 8, 2022 · 1 comment · Fixed by #1624
Closed

Glitches in audio when SRate is 11025 and SRC Best is selected #1622

philburk opened this issue Sep 8, 2022 · 1 comment · Fixed by #1624
Assignees
@philburk
Labels
bug
Milestone
V1.7.0

Comments

@philburk
Copy link
Collaborator

philburk commented Sep 8, 2022

Android version(s): S, T
Android device(s): all?
Oboe version: 1.5+
App name used for testing: OboeTester

Short description
Track internal bug b/245513523

Steps to reproduce

  1. Install Oboe Tester app (apk version: 2.3.0) on DUT
  2. Open oboe tester app
  3. Select Test Output from menu
  4. Select SRate - 11025
  5. Select SRC : Best
  6. Tap on OPEN
  7. Tap on START and observe

Expected behavior
Clean sine wave.

Actual behavior
Distorted sound.
@philburk philburk added the bug label Sep 8, 2022
@philburk philburk self-assigned this Sep 8, 2022
@philburk philburk added this to the V1.7.0 milestone Sep 8, 2022
@philburk
Copy link
Collaborator Author

There was a glitch that was happening when the interpolation wrapped around the coefficient table.
The coefficients at zero are not aligned with the last row. It is not a circular function.
I eliminated the glitch by adding a guard row to the coefficients table and not wrapping the indices.

philburk added a commit that referenced this issue Sep 14, 2022
@philburk
resampler fix glitch in some configurations
7770ca1 
Converting from 11025 to 48000 with Best quality had a strong glitch.
Added guard row to Coefficients table for interpolation.

Fixes #1622
@philburk philburk mentioned this issue Sep 14, 2022
Merged
philburk added a commit that referenced this issue Sep 14, 2022
@philburk
resampler fix glitch in some configurations
f032104 
Converting from 11025 to 48000 with Best quality had a strong glitch.
Added guard row to Coefficients table for interpolation.

Fixes #1622
philburk added a commit that referenced this issue Sep 16, 2022
@philburk
resampler fix glitch in some configurations (#1624)
68510d8 
Converting from 11025 to 48000 with Best quality had a strong glitch.
Added guard row to Coefficients table for interpolation.

Added a unit tests that scans all rate combinations.
Also added tests for specific settings for easier debugging.

Fixes #1622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
bug
Projects
None yet
Milestone
V1.7.0
Development

Successfully merging a pull request may close this issue.

resampler fix glitch in some configurations google/oboe
1 participant
@philburk