Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSLES stream.stop(timeoutNanos) may never time out #1061

Closed
philburk opened this issue Nov 2, 2020 · 0 comments · Fixed by #1065
Closed

OpenSLES stream.stop(timeoutNanos) may never time out #1061

philburk opened this issue Nov 2, 2020 · 0 comments · Fixed by #1065
Assignees
@philburk
Labels
bug
Milestone
v1.5

Comments

@philburk
Copy link
Collaborator

philburk commented Nov 2, 2020

The Oboe code for stop with a timeout looks odd. If you pass a timeoutNanoseconds > 0 then it can spin forever if the state does not change.
   

oboe/src/opensles/AudioStreamOpenSLES.cpp

Line 384 in 120b61d

if (timeoutNanoseconds <= 0) {

I think that should be:
    if (timeoutLeftNanos <= 0) {
@philburk philburk self-assigned this Nov 2, 2020
@philburk philburk added the bug label Nov 2, 2020
@philburk philburk added this to the v1.5 milestone Nov 2, 2020
philburk added a commit that referenced this issue Nov 3, 2020
@philburk
tests: test waitForStateChange() timeout
8bfd302 
Seems broken on OpenSL ES.

Tests for #1061
philburk added a commit that referenced this issue Nov 3, 2020
@philburk
oboe: fix timeout in waitForStateChange() for OpenSL ES
e4c15e6 
It used to not timeout and would spin until the state changed.

Fixes #1061
@philburk philburk mentioned this issue Nov 3, 2020
Closed
philburk added a commit that referenced this issue Nov 3, 2020
@philburk
tests: test waitForStateChange() timeout
7f55081 
Seems broken on OpenSL ES.

Tests for #1061
philburk added a commit that referenced this issue Nov 3, 2020
@philburk
oboe: fix timeout in waitForStateChange() for OpenSL ES
7f522ae 
It used to not timeout and would spin until the state changed.

Fixes #1061
This was referenced Nov 3, 2020
Merged
Merged
philburk added a commit that referenced this issue Nov 4, 2020
@philburk
tests: test waitForStateChange() timeout
d99a722 
Seems broken on OpenSL ES.

Tests for #1061
philburk added a commit that referenced this issue Nov 4, 2020
@philburk
oboe: fix timeout in waitForStateChange() for OpenSL ES
8d9dff4 
It used to not timeout and would spin until the state changed.

Fixes #1061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
bug
Projects
None yet
Milestone
v1.5
1 participant
@philburk