Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parselib handling 'other' chunks incorrectly #1027

Closed
jbeta51 opened this issue Sep 29, 2020 · 1 comment
Closed

parselib handling 'other' chunks incorrectly #1027

jbeta51 opened this issue Sep 29, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@jbeta51
Copy link
Contributor

jbeta51 commented Sep 29, 2020

Android version(s): all
Android device(s): all
Oboe version: 1.4.3

Short description
The wav reader will crash when asked to parse a wav file with a chunk type other than RIFF, fmt, or data. In the 'else' branch, we want to skip the contents of 'chunk', but we instead try to access the length of mDataChunk, which is null before hitting the data tag.

Steps to reproduce
Create a meminputstream with a wav file that contains a chunk type such as 'LIST'

Expected behavior
The LIST chunk gets parsed and skipped.

Actual behavior
When trying to skip the chunk, it dereferences the wrong chunk throwing an error.

Device
All

@jbeta51 jbeta51 added the bug label Sep 29, 2020
@jbeta51
Copy link
Contributor Author

jbeta51 commented Sep 29, 2020

jbeta51 added a commit to jbeta51/oboe that referenced this issue Sep 29, 2020
@philburk philburk added this to the v1.5 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants