-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken brotli build (upstream brotli dropped makefile support and sources.lst file) #150
Conversation
Also make the build files real-life with optimizations (so everyone doesn't have to search for the best way to compile things).
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
hi @wyattoday have any update? |
It's up to @google-admin and @eustas to merge the PR. I just submitted it because we need it and figured everyone could benefit from the work we put in. See #148 (comment) for the solution in the meantime. Google has mostly abandoned this project for some odd reason (like they abandon every piece of technology that doesn't generate them hundreds of billions of advertising dollars every year). |
Thanks for the PR. Will land soon. |
thanks for your update. |
I'm terribly sorry, but landing is blocked by CLA check. @wyattoday could you sign it, please. |
Yep. Done. |
Awesome. Landing. |
This PR fix the latest commit by fixing the config file to include the correct static libraries, drop support for the sources.lst file (which no longer exists), and updates the build instructions to get people up and running quickly.
Fixes #148
Fixes #149
Fixes #151