Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken brotli build (upstream brotli dropped makefile support and sources.lst file) #150

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

wyattoday
Copy link
Contributor

@wyattoday wyattoday commented Sep 5, 2023

This PR fix the latest commit by fixing the config file to include the correct static libraries, drop support for the sources.lst file (which no longer exists), and updates the build instructions to get people up and running quickly.

Fixes #148
Fixes #149
Fixes #151

Also make the build files real-life with optimizations (so everyone doesn't have to search for the best way to compile things).
@google-cla
Copy link

google-cla bot commented Sep 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hao159
Copy link

hao159 commented Sep 7, 2023

hi @wyattoday have any update?

@wyattoday
Copy link
Contributor Author

wyattoday commented Sep 7, 2023

@hao159

It's up to @google-admin and @eustas to merge the PR. I just submitted it because we need it and figured everyone could benefit from the work we put in.

See #148 (comment) for the solution in the meantime.

Google has mostly abandoned this project for some odd reason (like they abandon every piece of technology that doesn't generate them hundreds of billions of advertising dollars every year).

@eustas
Copy link
Collaborator

eustas commented Sep 7, 2023

Thanks for the PR. Will land soon.

@hao159
Copy link

hao159 commented Sep 7, 2023

@hao159

It's up to @google-admin and @eustas to merge the PR. I just submitted it because we need it and figured everyone could benefit from the work we put in.

See #148 (comment) for the solution in the meantime.

Google has mostly abandoned this project for some odd reason (like they abandon every piece of technology that doesn't generate them hundred of billions of advertising dollars every year).

thanks for your update.

@eustas
Copy link
Collaborator

eustas commented Sep 7, 2023

I'm terribly sorry, but landing is blocked by CLA check. @wyattoday could you sign it, please.

@wyattoday
Copy link
Contributor Author

I'm terribly sorry, but landing is blocked by CLA check. @wyattoday could you sign it, please.

Yep. Done.

@eustas
Copy link
Collaborator

eustas commented Sep 7, 2023

Awesome. Landing.

@eustas eustas merged commit 63ca02a into google:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot find -lbrotlienc make[1]: Nothing to be done for 'modules' Statically compiled installation fails
5 participants