Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EventAction import to resolve dev-server compilation error #703

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

aaronkanzer
Copy link
Contributor

@aaronkanzer aaronkanzer commented Jan 27, 2025

EventAction is an unused import -- in which type-checking fails when running npm run dev-server locally -- simple PR to remove import until it is either used or intentionally removed

This issue persisted when trying on node >= 22 (verified locally via nvm use 22 and nvm use 23)

Screenshot 2025-01-27 at 2 23 16 PM

Cc @kabilar

Copy link

google-cla bot commented Jan 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aaronkanzer
Copy link
Contributor Author

@aranega -- I think this error may have been introduced via this commit from 4 days ago: 6f9335f

@aranega
Copy link
Contributor

aranega commented Jan 27, 2025

Indeed, it seems that I missed something regarding the type inclusion. It's weird the linter didn't catch it on the PR. This line can be removed for sure.

@jbms jbms merged commit 186674a into google:master Jan 27, 2025
1 check failed
@aaronkanzer aaronkanzer deleted the akanzer-event-action branch January 27, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants