-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated to three.js r151 #4186
updated to three.js r151 #4186
Conversation
@mrdoob This is looking great overall! I can't quite figure out why the last two renders changed. Not saying it's a regression, but I'd like to understand for sake of glTF compliance and other renderers. Any thoughts? |
Yeah, @mrdoob there's definitely something going on here; these used to look a lot more similar: https://modelviewer.dev/fidelity/#khronos-LightsPunctualLamp This one's also looking not great - it was too dark before, and now it's much too light: https://modelviewer.dev/fidelity/#khronos-GlamVelvetSofa |
@mrdoob Okay, my best guess is whatever is causing that change to the LightsPunctualLamp also blew out our default lighting, so that's become a blocker. |
Okay, nevermind, I realized I just got hit by mrdoob/three.js#25479. The one-liner fixed it and it only took an hour to figure it out, so not bad overall. And apparently GlamVelvetSofa has a punctual light (!?!). |
Hi, this works great on model viewer and android, but when autogenerated usdz file is opened on Iphone second UV map doesn't work. Is there some naming rule for UV maps, or it just isnt supported for USDZ autogeneration? |
The current state of USDZ is a bit of a mess: |
In theory this should work but I don't think it does. |
In gerneral autogeneration works perfectly except for models with animations and multiple uv maps |
@elalish do you maybe have some info about multiple UV sets and USDZ autogeneration. Does this work or still isnt supported? I have tried with only AO on the second set and I cant make it work… thanks! |
I'm guessing you're looking for this, which we can pull down at the end of the month when it's released. |
@elalish @mrdoob thank you for help, I'm not a developer, so maybe I don't understand everything the best... But when I convert glb file using this online convertor (https://arize.io/tools/usdz-converter/) to usdz Here are the files: So somehow this online converter is converting in the right way comparing to autogeneration. So if I understand correctly, this will be fixed by the end of the month as elalish wrote (mrdoob/three.js#26023)? Thanks! |
That's correct - please help us test and verify once that lands. |
Great!! off course I will test in detail when it will be released |
* updated to three.js r151 * r151.2 * updated goldens
This reverts commit 640b554.
Lots of rendering improvements this time, most notably that multiple UV channels and texture transforms are fully and properly supported now, which is a huge win especially for models using a tiled texture swatch as well as a non-tiled AO map, e.g. Sheen Chair:





Further proof:
Also significant improvement of back-side reflections of transmissive materials:
I need to dig a little deeper into what's changed with punctual lights:
And also with the Glam sofa: