Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept a const value ref in Context::set #34

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

cebtenzzre
Copy link
Contributor

@cebtenzzre cebtenzzre commented Jan 29, 2025

Everything seems to compile fine when this is const. It being non-const makes it hard to pass in a temporary (rvalue).

edit: I intend to sign the CLA but it's going to take me some time to figure out the Google Groups stuff that I need.

Copy link

google-cla bot commented Jan 29, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cebtenzzre
Copy link
Contributor Author

Sorry for the delay, it took some reading to understand that I could just sign the individual CLA. That is done now.

@ochafik ochafik merged commit 1d5ddf1 into google:main Jan 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants