-
Notifications
You must be signed in to change notification settings - Fork 28
Replace pre-go1.11 vendoring with a go1.11 module. #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait for Lantao to approve too.
Hm, after this change, how is this expected to be built? go build doesn't work without the vendors. @brb-g |
I'm fixing up the travis build now -- I think it's broken because the Travis config specifies go 1.11 but the
|
@brb-g Sounds good. Fixing build and good to go. :) |
@brb-g I think you need to add GO111MODULE=on to the env because travis puts the source under the GOPATH. If source is under GOPATH then go will not download dependencies when running 'go build' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.