Make our Collector APIs available in guava-android.
#7194
Merged
+192
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_629191336
branch
from
aa857af to
876873c
Compare
(for example, `ImmutableList.toImmutableList()`) For now, we're making them `@Beta` just in case users encounter enough problems that we find it less disruptive to revert this change than to keep it. However, we plan to remove `@Beta` soon, at which point we'll be committed to this APIs. If you use Guava under Android, please [test with Guava 33.0.0 or higher](https://groups.google.com/g/guava-announce/c/9-dw_C6G_NM), ideally with 34.0.0 or higher (which will contain this commit), and [report any problems](https://github.com/google/guava/issues/new?assignees=&labels=type%3Ddefect&projects=&template=bug_report.yaml). Our expectation is that this commit should not cause problems, even for users who don't use enable [library desugaring](https://developer.android.com/studio/write/java11-default-support-table). But we will see what happens in wild. Of course, if you want to actually _use_ these APIs, then you'll need to [enable library desugaring](https://developer.android.com/studio/write/java8-support#library-desugaring) or target a [new enough version of Android](https://developer.android.com/reference/java/util/stream/Stream), just as with any other `Stream`-based APIs. (progress toward #6567) RELNOTES=`collect`: Made our `Collector` APIs (e.g., `ImmutableList.toImmutableList()`) available in `guava-android`. PiperOrigin-RevId: 629491350
copybara-service
bot
force-pushed
the
test_629191336
branch
from
876873c to
96fca0b
Compare
copybara-service
bot
closed this pull request by merging all changes
into
master
in
96fca0b
Sorry, that will be 33.2.0, not 34.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make our
CollectorAPIs available inguava-android.(for example,
ImmutableList.toImmutableList())For now, we're making them
@Betajust in case users encounter enough problems that we find it less disruptive to revert this change than to keep it. However, we plan to remove@Betasoon, at which point we'll be committed to this APIs. If you use Guava under Android, please test with Guava 33.0.0 or higher, ideally with 34.0.0 or higher (which will contain this commit), and report any problems.Our expectation is that this commit should not cause problems, even for users who don't use enable library desugaring. But we will see what happens in wild.
Of course, if you want to actually use these APIs, then you'll need to enable library desugaring or target a new enough version of Android, just as with any other
Stream-based APIs.(progress toward #6567)
RELNOTES=
collect: Made ourCollectorAPIs (e.g.,ImmutableList.toImmutableList()) available inguava-android.