Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEFINES_MODULE to support downstream usage of static libs #385

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

thomasvl
Copy link
Member

@thomasvl thomasvl commented Apr 1, 2024

Fixes #384

@thomasvl
Copy link
Member Author

thomasvl commented Apr 1, 2024

@paulb777 @mdmathias - this seem good?

@paulb777
Copy link
Member

paulb777 commented Apr 1, 2024

I can stage the modified podspec to https://github.com/firebase/SpecsStaging and make sure it doesn't impact Firebase tests - and let you know tomorrow.

@paulb777
Copy link
Member

paulb777 commented Apr 1, 2024

I staged a version (without visionOS) at firebase/SpecsStaging@948fd05 cc:@ncooke3

@mdmathias
Copy link

I'm going to be making a similar change for AppAuth-iOS.

@paulb777
Copy link
Member

paulb777 commented Apr 2, 2024

Firebase nightly tests look good with the gtm-session-fetcher podspec update - firebase/firebase-ios-sdk#12669

@thomasvl
Copy link
Member Author

thomasvl commented Apr 2, 2024

Thanks, merging.

@thomasvl thomasvl merged commit a257ea1 into google:main Apr 2, 2024
11 checks passed
@thomasvl thomasvl deleted the support_modular branch April 2, 2024 16:03
paulb777 added a commit to firebase/SpecsStaging that referenced this pull request Apr 2, 2024
@vonovak
Copy link

vonovak commented Apr 13, 2024

Hello and thanks for this fix 🙂

@thomasvl would it be possible to have this released soon?

There are downstream packages building on top of this, such as wrappers for Google Sign in SDK for React Native and maybe Flutter and others that are hitting #384 and having this published would make it easy to use the latest versions.

I'm aware that there are workaround that are not too complicated even, but requiring people to take extra steps, however easy and nicely documented means friction and questions in issue tracker 🙈 .

Thank you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants