Update survey proto to support data sharing agreement

[nwkotto]

Part 1 for #1856

[sufyanAbbasi]

Awesome! And I believe we will also want an associated response field on the Submission too, since we'll want to save the user's response to the DB in case the survey organizers change the sharing consent after the fact. Maybe just an enum will suffice?

[gino-m]

Awesome! And I believe we will also want an associated response field on the Submission too, since we'll want to save the user's response to the DB in case the survey organizers change the sharing consent after the fact. Maybe just an enum will suffice?

Not sure about storing Submission - a Firestore query would scan all submissions to find out if one has the consent bit. That said, Survey isn't editable.. maybe a new collection specifically for this purpose? For a first plass we'll just ask once per session per survey, so nothing needs to be stored.

[nwkotto]

Awesome! And I believe we will also want an associated response field on the Submission too, since we'll want to save the user's response to the DB in case the survey organizers change the sharing consent after the fact. Maybe just an enum will suffice?

Not sure about storing Submission - a Firestore query would scan all submissions to find out if one has the consent bit. That said, Survey isn't editable.. maybe a new collection specifically for this purpose? For a first plass we'll just ask once per session per survey, so nothing needs to be stored.

So are we saying we're ok to not include any submission bit about consent being agreed to? Or how are we expecting that to be captured?

[gino-m]

A few nits, thanks @nwkotto

[gino-m]

Awesome! And I believe we will also want an associated response field on the Submission too, since we'll want to save the user's response to the DB in case the survey organizers change the sharing consent after the fact. Maybe just an enum will suffice?

Not sure about storing Submission - a Firestore query would scan all submissions to find out if one has the consent bit. That said, Survey isn't editable.. maybe a new collection specifically for this purpose? For a first plass we'll just ask once per session per survey, so nothing needs to be stored.

So are we saying we're ok to not include any submission bit about consent being agreed to? Or how are we expecting that to be captured?

Sorry, I think I misunderstood the original question. Adding a bit to submissions as to which consent was given is a good idea. For now the Android client will need to store that consent was given on the first data collection flow locally, in the future we may store that in the remote db as well.

[gino-m]

I made a few small adjustments, LGTM!