Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake compatibility with version 2.8 #3274

Closed
bstaletic opened this issue Feb 11, 2021 · 4 comments
Closed

CMake compatibility with version 2.8 #3274

bstaletic opened this issue Feb 11, 2021 · 4 comments

Comments

@bstaletic
Copy link

Since cmake 3.19, the following warning is shown:

CMake Deprecation Warning at CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


CMake Deprecation Warning at googlemock/CMakeLists.txt:45 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


CMake Deprecation Warning at googletest/CMakeLists.txt:56 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
@derekmauro
Copy link
Member

I thought someone fixed this a few weeks ago. Are you using the latest HEAD?

@bstaletic
Copy link
Author

@ghost
Copy link

ghost commented Mar 2, 2021

Hello,
#3094 is merged quite recently (Jan/2021)
and so I think using 1.10.0 which was released in 2019 can't resolve above warnings

@bstaletic
Copy link
Author

Oh, thanks for pointing that out. I was under the impression that all of cmake 2.8.x is raising warnings, so I didn't try HEAD. Yes, HEAD doesn't raise those warnings. Apologies for the noise.

Holzhaus added a commit to Holzhaus/mixxx that referenced this issue May 22, 2021
GoogleTest now follows the Abseil [Live at Head] philosophy and recommends
using the latest commit in the master branch.

The 1.10.x release causes a [CMake deprecation warning], which is
already fixed on master. Hence, this updates the googletest libraries to
google/googletest@9741c42.

[Live at Head]: https://github.com/google/googletest#live-at-head
[CMake deprecation warning]: google/googletest#3274
Holzhaus added a commit to Holzhaus/mixxx that referenced this issue May 22, 2021
GoogleTest now follows the Abseil [Live at Head] philosophy and recommends
using the latest commit in the master branch.

The 1.10.x release causes a [CMake deprecation warning], which is
already fixed on master. Hence, this updates the googletest libraries to
google/googletest@9741c42.

[Live at Head]: https://github.com/google/googletest#live-at-head
[CMake deprecation warning]: google/googletest#3274
Holzhaus added a commit to Holzhaus/mixxx that referenced this issue May 24, 2021
GoogleTest now follows the Abseil [Live at Head] philosophy and recommends
using the latest commit in the master branch.

The 1.10.x release causes a [CMake deprecation warning], which is
already fixed on master. Hence, this updates the googletest libraries to
google/googletest@9741c42.

[Live at Head]: https://github.com/google/googletest#live-at-head
[CMake deprecation warning]: google/googletest#3274
Holzhaus added a commit to Holzhaus/mixxx that referenced this issue May 25, 2021
GoogleTest now follows the Abseil [Live at Head] philosophy and recommends
using the latest commit in the master branch.

The 1.10.x release causes a [CMake deprecation warning], which is
already fixed on master. Hence, this updates the googletest libraries to
google/googletest@9741c42.

[Live at Head]: https://github.com/google/googletest#live-at-head
[CMake deprecation warning]: google/googletest#3274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants