Replace the tuple! macro with an implementation of Matcher for tuples
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hovinen
force-pushed
the
impl-matcher-for-tuples
branch
3 times, most recently
from
75ae2ed to
50b8b80
Compare
…ples. This means that one can just put a bunch of matchers into a tuple and the result will itself be a matcher against corresponding tuples: ``` let value = (1, 2); verify_that!(value, (eq(1), eq(2))) ``` There is no need for a separate macro for this, since one can implement `Matcher` for a tuple of matchers directly. This is a breaking change, since it eliminates the `tuple!` macro. To port existing code, one just removes the call to `tuple!` and adds a trailing comma if necessary.
hovinen
force-pushed
the
impl-matcher-for-tuples
branch
from
50b8b80 to
6837e48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that one can just put a bunch of matchers into a tuple and the result will itself be a matcher against corresponding tuples:
There is no need for a separate macro for this, since one can implement
Matcherfor a tuple of matchers directly.This is a breaking change, since it eliminates the
tuple!macro. To port existing code, one just removes the call totuple!and adds a trailing comma if necessary.