Add a shim to ease integration with the [proptest](https://crates.io/crates/proptest) crate. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hovinen
force-pushed
the
add-proptest-support
branch
6 times, most recently
from
15ec82d to
055ef56
Compare
…crates/proptest) crate. Previously, it was awkward to use GoogleTest Rust assertions in Proptest property tests and to return GoogleTest `Result` from such tests. This required a fair amount of manual type conversion. This adds two trait implementations behind an optional dependency on the `proptest` crate: * An implementation of 'IntoTestResult` allows easily converting the output of `TestRunner` into a GoogleTest `Result`. * An implementation of `From<TestAssertionFailure>` for `TestCaseError` allows easily using GoogleTest macros such as `verify_that!` inside `TestRunner::run`. In particular, with this change, it is much easier to have property-based tests using `proptest` which do not panic on failure but rather communicate failures using `Result`, as is idiomatic in GoogleTest. Since proptest requires Rust 1.60, this also modifies the CI action so that the test against Rust 1.59 only runs with the --no-default-features flag. This also adds a section on integrations to the crate-level documentation covering both the new proptest integration and the existing [anyhow](https://crates.io/crates/anyhow) integration.
hovinen
force-pushed
the
add-proptest-support
branch
from
055ef56 to
dc128d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was awkward to use GoogleTest Rust assertions in Proptest property tests and to return GoogleTest
Resultfrom such tests. This required a fair amount of manual type conversion.This adds two trait implementations behind an optional dependency on the
proptestcrate:allows easily converting the output ofTestRunnerinto a GoogleTestResult`.From<TestAssertionFailure>forTestCaseErrorallows easily using GoogleTest macros such asverify_that!insideTestRunner::run.In particular, with this change, it is much easier to have property-based tests using
proptestwhich do not panic on failure but rather communicate failures usingResult, as is idiomatic in GoogleTest.