feat!: Change Hook Config field from map to *HookConfig

[himazawa]

Fixes: #3072.

BREAKING CHANGE: Changes Hook.Config from map[string]interface{} to *HookConfig.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[himazawa]

I would like to sign the CLA but there is no way to add the noreply.github.com email to the CLA account.

[gmlewis]

Thank you, @himazawa.

[gmlewis]

I would like to sign the CLA but there is no way to add the noreply.github.com email to the CLA account.

Did you read the instructions for email addresses here: https://github.com/google/go-github/pull/3073/checks?check_run_id=21540833172 ?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b8c7fa) 97.72% compared to head (ea29fb5) 92.86%.
Report is 8 commits behind head on master.

❗ Current head ea29fb5 differs from pull request most recent head bf1d28c. Consider uploading reports for the commit bf1d28c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3073      +/-   ##
==========================================
- Coverage   97.72%   92.86%   -4.86%     
==========================================
  Files         153      170      +17     
  Lines       13390    11400    -1990     
==========================================
- Hits        13085    10587    -2498     
- Misses        215      723     +508     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[himazawa]

Did you read the instructions for email addresses here: https://github.com/google/go-github/pull/3073/checks?check_run_id=21540833172 ?

@gmlewis yes I did, there is no way from the CLA panel to change the email, other than adding it from gmail.
The issue is that gmail considers 73994521+himazawa​@users.noreply.github.com an invalid email.

[gmlewis]

Did you read the instructions for email addresses here: https://github.com/google/go-github/pull/3073/checks?check_run_id=21540833172 ?

@gmlewis yes I did, there is no way from the CLA panel to change the email, other than adding it from gmail. The issue is that gmail considers 73994521+himazawa​@users.noreply.github.com an invalid email.

That is a throw-away email address that you will never use. Mine is [email protected] and it works fine and I never use it, so I'm not sure I understand what the problem is. I registered my real email address with the Google CLA, signed it, and then added the fake email to GitHub (in addition to my real one) and use the fake email in my ~/.gitconfig and everything works fine.

[gmlewis]

Well, looks like you got it resolved whatever the problem was.

[gmlewis]

Please run step 4 of CONTRIBUTING.md and then push (not force-push) the changes to this PR.

[himazawa]

Done

[gmlewis]

Thank you, @himazawa !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[valbeat]

LGTM!

[gmlewis]

Thank you, @valbeat !
Merging.