Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tokenauth example as debugging tool #1853

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Apr 9, 2021

When assisting someone with GitHub auth token issues, I realized that this example could be more useful if it printed out the rate limit information.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Apr 9, 2021
@gmlewis gmlewis requested a review from wesleimp April 9, 2021 10:39
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #1853 (0fbc10f) into master (d2bad3e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1853   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         105      105           
  Lines        6720     6720           
=======================================
  Hits         6561     6561           
  Misses         86       86           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2bad3e...0fbc10f. Read the comment docs.

Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@gmlewis
Copy link
Collaborator Author

gmlewis commented Apr 14, 2021

Thank you, @wesleimp .
Merging.

@gmlewis gmlewis merged commit b220168 into google:master Apr 14, 2021
@gmlewis gmlewis deleted the tokenauth-example branch April 14, 2021 12:34
This was referenced May 21, 2021
This was referenced Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants