Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces go:generate #1828

Closed

Conversation

migueleliasweb
Copy link
Contributor

No description provided.

@migueleliasweb migueleliasweb marked this pull request as draft March 25, 2021 09:08
@google-cla
Copy link

google-cla bot commented Mar 25, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 25, 2021
@migueleliasweb
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Mar 25, 2021
@migueleliasweb migueleliasweb force-pushed the client-interfaces-autogen branch from 7cf7474 to eaa8ed0 Compare March 25, 2021 09:24
@migueleliasweb
Copy link
Contributor Author

I just found out that many of the Services like RepositoriesService are split in multiple files. Have said that, this might be a bit more challenging that I first thought as the tool that I used doesn't seem to support multiple files to generate the interface. =/

I will come up with something, don't worry. 🚀

@migueleliasweb migueleliasweb force-pushed the client-interfaces-autogen branch from eaa8ed0 to abd4f11 Compare March 25, 2021 09:30
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other requirement... please do not pull in any external dependencies for ease of maintainability of this repo.

Feel free to close this and assign the issue back to me, and I will implement it.

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 14, 2021

Closing this PR as we will not be pulling in an external resource when we have an alternative implementation (#1832) that does not require any.

@gmlewis gmlewis closed this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants