Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ArchiveFormat #1534

Merged
merged 2 commits into from
May 28, 2020
Merged

Export ArchiveFormat #1534

merged 2 commits into from
May 28, 2020

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented May 22, 2020

Fixes: #1533.

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label May 22, 2020
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 22, 2020
@codecov
Copy link

codecov bot commented May 22, 2020 •
edited
Loading

Codecov Report

Merging #1534 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1534   +/-   ##
=======================================
  Coverage   68.01%   68.01%           
=======================================
  Files          94       94           
  Lines        8560     8560           
=======================================
  Hits         5822     5822           
  Misses       1852     1852           
  Partials      886      886
Impacted Files Coverage Δ
github/repos_contents.go 62.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37dd2d...aa15175. Read the comment docs.

@gmlewis gmlewis requested review from gauntface and wesleimp May 22, 2020 12:53
@gmlewis gmlewis mentioned this pull request May 28, 2020
Merged
andrew-waters
andrew-waters approved these changes May 28, 2020
View reviewed changes
Copy link

@andrew-waters andrew-waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gmlewis
Copy link
Collaborator Author

gmlewis commented May 28, 2020

Friendly ping, @wesleimp - I would like to get this breaking API change into the repo before releasing v32.0.0 so that we don't have to immediately bump the version after release.

@gmlewis
Copy link
Collaborator Author

gmlewis commented May 28, 2020

Thank you, @andrew-waters! Your review is greatly appreciated! Oh, and @z0mbix too! Thank you!
You all rock!

@gmlewis
Copy link
Collaborator Author

gmlewis commented May 28, 2020

Merging.

@gmlewis gmlewis merged commit ec3758e into google:master May 28, 2020
@gmlewis gmlewis deleted the i-1533-export-archiveFormat branch May 28, 2020 12:15
wesleimp
wesleimp approved these changes May 28, 2020
View reviewed changes
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@gmlewis
Copy link
Collaborator Author

gmlewis commented May 28, 2020

Ah, thank you, @wesleimp !!! You rock too! 😄

@wesleimp
Copy link
Collaborator

Friendly ping, @wesleimp - I would like to get this breaking API change into the repo before releasing v32.0.0 so that we don't have to immediately bump the version after release.

@gmlewis I somehow missed the notification. Sorry for that

@gmlewis
Copy link
Collaborator Author

gmlewis commented May 28, 2020

No problem, @wesleimp ! It was no big deal, but today we got a request for a new release, so this one suddenly became important. Thanks for your fast response!

n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@gmlewis
Export ArchiveFormat (google#1534)
13ab973 
Fixes: google#1533.
This was referenced May 28, 2021
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
This was referenced Jun 6, 2021
Closed
Closed
@renovate renovate bot mentioned this pull request Jun 6, 2021
Closed
1 task
This was referenced Jun 21, 2021
Merged
Closed
Closed
Merged
Closed
Closed
This was referenced Jun 30, 2021
Closed
Closed
This was referenced Jul 9, 2021
Closed
Merged
Merged
Closed
Closed
Closed
This was referenced Aug 11, 2021
Closed
Closed
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z0mbix z0mbix z0mbix approved these changes

@andrew-waters andrew-waters andrew-waters approved these changes

@wesleimp wesleimp wesleimp approved these changes

@gauntface gauntface Awaiting requested review from gauntface

Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The archiveFormat type is not exported but used in an exported API GetArchiveLink
5 participants
@gmlewis @wesleimp @z0mbix @andrew-waters @googlebot