gen-accessors should skip Client, service structs and unexported fields.

[dmitshur]

There are two issues with gen-accessors.go generating accessors it should not be (/cc @gmlewis FYI). It's relatively harmless, but should be fixed.

First, gen-accessors.go does not skip unexported fields, which causes it to generate accessors that it shouldn't. For example:

// Getclient returns the client field.
func (s *service) Getclient() *Client {
	if s == nil {
		return nil
	}
	return s.client
}

Second, it does not skip certain structs that it should skip, including Client, service, and perhaps others. It should only generate accessors for structs that are mapped to GitHub objects. For example:

[sahildua2305]

@shurcooL I'd like to tackle this. What do you think about having an extended list of blacklisted structs to avoid while generating accessor methods?

[dmitshur]

Thanks!

I think adding a list of blacklisted structs is the way to go. There's only a couple of them.