-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch tests to use github.com/google/go-cmp package #1851
Comments
and just to be clear, we should use go-cmp for all of our non-error values (of which there appear to be 600+ comparisons?!). Switching to go1.13's |
@willnorris Can I start working on this? |
have at it! (With so many instances, you might want to do a global find and replace, or use |
Hi @photongupta. Are You Still working on this issue. |
Replaced all reflect.DeepEqual comparisons in test files with cmp.Equal. Fixes: google#1851
Replaced all reflect.DeepEqual comparisons in test files with cmp.Equal. Fixes: google#1851
Replaced all reflect.DeepEqual comparisons in test files with cmp.Equal. Fixes: google#1851
Replaced all reflect.DeepEqual comparisons in test files with cmp.Equal. Fixes: #1851
#1846 calls out not using
reflect.DeepEqual
for comparing error values, but in reality we shouldn't be using it all. https://pkg.go.dev/github.com/google/go-cmp/cmp is designed to be a much safer alternative, so we should use that for tests.The text was updated successfully, but these errors were encountered: