gnostic-summary: fix plugin to write output in the same directory as …

…its input file. (#178) * gnostic-summary writes output in the same directory as its input file. Modify the file name generation so that "summary.txt" gets written in the same directory as the input spec. This is typically only relevant when gnostic is run on an input file with a hierarchical path, e.g. gnostic xkcd.com/1.0.0/openapi.yaml --errors_out=. * Update plugin test data.
google · Jun 4, 2020 · 966d1db · 966d1db
1 parent 0a63761
commit 966d1db
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 9 deletions.
diff --git a/discovery/discovery.pb.go b/discovery/discovery.pb.go
diff --git a/extensions/extension.pb.go b/extensions/extension.pb.go
diff --git a/metrics/vocabulary.pb.go b/metrics/vocabulary.pb.go
diff --git a/openapiv2/OpenAPIv2.pb.go b/openapiv2/OpenAPIv2.pb.go
diff --git a/openapiv3/OpenAPIv3.pb.go b/openapiv3/OpenAPIv3.pb.go
diff --git a/plugins/gnostic-summary/main.go b/plugins/gnostic-summary/main.go
@@ -17,6 +17,9 @@
 package main
 
 import (
+	"log"
+	"path/filepath"
+
 	"github.com/golang/protobuf/proto"
 	openapiv2 "github.com/googleapis/gnostic/openapiv2"
 	openapiv3 "github.com/googleapis/gnostic/openapiv3"
@@ -110,8 +113,11 @@ func main() {
 			}
 		}
 	}
+	outputName := filepath.Join(
+		filepath.Dir(env.Request.SourceName), "summary.txt")
+	log.Printf("generating %+v", outputName)
 	f := &plugins.File{
-		Name: "summary.txt",
+		Name: outputName,
 		Data: []byte(code.String()),
 	}
 	env.Response.Files = append(env.Response.Files, f)

diff --git a/plugins/plugin.pb.go b/plugins/plugin.pb.go
diff --git a/surface/surface.pb.go b/surface/surface.pb.go
diff --git a/testdata/v2.0/yaml/sample-petstore.out b/testdata/v2.0/yaml/sample-petstore.out
@@ -1,6 +1,6 @@
 
 
-summary.txt -------------------- 
+../examples/v2.0/yaml/summary.txt -------------------- 
 Swagger: 2.0
 Host: petstore.swagger.io
 BasePath: /v1