Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gapis/gles: Workarounds for EGL_EXT_buffer_age #845

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

ben-clayton
Copy link
Contributor

@ben-clayton ben-clayton commented Aug 1, 2017

The Android framework heavily uses eglSwapBuffersWithDamageKHR to update just the portions of the compositor that got touched.

@ben-clayton ben-clayton requested a review from dsrbecky August 1, 2017 18:11
Copy link
Contributor

@dsrbecky dsrbecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The damage is just a hint, the commands are semantically equivalent.
Is something else broken instead?

@ben-clayton
Copy link
Contributor Author

Okay, the description I gave is misleading - I guess at the framebuffer level, it could be invalidating, but from an end-user perspective, marking everything outside of that partial update with undefined is just not helpful.

Most people would expect and more importantly want to see the final composition, not the partial updates.

I've updated the comment.

@dsrbecky
Copy link
Contributor

dsrbecky commented Aug 1, 2017

Can you share a trace with the problem you are trying to solve?
eglSwapBuffersWithDamageKHR are eglSwapBuffers should be equivalent. Otherwise the app is wrong and we should be showing the pattern.

Copy link
Contributor

@dsrbecky dsrbecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but remember to create the bug to implement buffer age extension and revert this.

@ben-clayton ben-clayton changed the title gapis/gles: Fixes for eglSwapBuffersWithDamageKHR. gapis/gles: Workarounds for EGL_EXT_buffer_age Aug 1, 2017
@ben-clayton ben-clayton merged commit 38ea2bc into google:master Aug 1, 2017
@ben-clayton ben-clayton deleted the swap-buf-with-dmg branch August 1, 2017 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants