Automatically unlock device screen when possible #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arguably fix #2747 |
pmuetschard
reviewed
May 31, 2019
This is a refactor of the device screen unlock logic, to simplify it down to UnlockScreen() which tries to get the screen on and unlocked, and reports whether it succeeded. When the screen cannot be automatically unlocked, the new error message clearly tells the user to unlock the device screen. Along the way, this removes the feature of putting back the screen off if it was off before tracing. I argue this was hardly desirable in any case.
pmuetschard
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the device screen unlock logic, to simplify it down to two functions:
UnlockScreen() which tries to get the screen on and unlocked
IsScreenUnlocked() which returns true if the screen is on and unlocked
When the screen cannot be automatically unlocked, the new error message clearly tells the user to unlock the device screen.
Along the way, this removes the feature of putting back the screen off if it was off before tracing. I argue this was hardly desirable in any case.
Fixes #2747