Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set the layer property when using settings. #2711

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

pmuetschard
Copy link
Member

When using the layer settings to trace, don't also set the global layer property.

This is something that should have been part of #2700, but must have been lost in one of the merges/rebases.

When using the layer settings to trace, don't also set the global
layer property.

This is something that should have been part of google#2700, but must
have been lost in one of the merges/rebases.
Copy link
Contributor

@hevrard hevrard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmuetschard pmuetschard merged commit da96dc6 into google:master Apr 9, 2019
@pmuetschard pmuetschard deleted the no_vk_prop branch April 9, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants