Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the connect timeout to the gapii socket. #2255

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Increase the connect timeout to the gapii socket. #2255

merged 1 commit into from
Sep 27, 2018

Conversation

pmuetschard
Copy link
Member

On Windows, it seems, 1 second is not enough to connect to the
adb forwarded port.

Fixes #2247

AWoloszyn
AWoloszyn approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@AWoloszyn AWoloszyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be a change in how windows handles stuff, since it has worked in the past.

@pmuetschard
Increase the connect timeout to the gapii socket.
d69c33f 
On Windows, it seems, 1 second is not enough to connect to the
adb forwarded port.
@pmuetschard pmuetschard merged commit 055af70 into google:master Sep 27, 2018
@pmuetschard pmuetschard deleted the timeout branch September 27, 2018 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AWoloszyn AWoloszyn AWoloszyn approved these changes

@ben-clayton ben-clayton Awaiting requested review from ben-clayton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmuetschard @AWoloszyn