Vulkan: State rebuilding optimization reduce the number of commands #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qining
force-pushed
the
command-opt-2-squash
branch
from
b2009ef to
fb446c0
Compare
Qining
changed the title
|
Ready for review |
Qining
force-pushed
the
command-opt-2-squash
branch
from
0e8cc38 to
a3fb87d
Compare
This CL does: 1) Batch buffer->image copy commands, defer the command submission until a scratch memory is full. This reduces the number of VkCommandBufferBegin/End, VkQueueSubmit, VkQueueWaitIdle calls. 2) Batch the commands for 'priming by rendering' in the similar way. 3) Track image last bound queue at 'ImageLevel' level. For now, on a typical Vulkan app, this reduce 30% of the initial commands. For `gapit report`, saves ~10% of time.
Qining
force-pushed
the
command-opt-2-squash
branch
from
a3fb87d to
18e4079
Compare
AWoloszyn
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL does:
Lazily reserve 128MB device memory for the use of scratch buffers.
Batch buffer->image copy commands, defer the command submissions until
the reserved scratch memory is full. This reduces the number of
VkCommandBufferBegin/End, VkQueueSubmit, VkQueueWaitIdle calls.
Batch the commands for 'priming by rendering' and 'priming by imageStore' in the similar way.
Track image last bound queue at 'ImageLevel' level.
For now, on a typical Vulkan app, this reduce 30% of the initial
commands. For
gapit report, saves ~10% of time.