Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy the GLES state block #24

Closed
ben-clayton opened this issue Mar 6, 2017 · 5 comments
Closed

Tidy the GLES state block #24

ben-clayton opened this issue Mar 6, 2017 · 5 comments

Comments

@ben-clayton
Copy link
Contributor

Add a global for CurrentState so we don't have to always go though the map!(ThreadID, ref!Context) Contexts global at the root of the state tree (ensure you update all Link() logic in gles/links.go).

Find a way to hide GLXContexts, WGLContexts, CGLContexts, EGLContexts.

Try navigating the state block in GAPIC, make changes to the API file to try and make state navigation not suck.

@ben-clayton ben-clayton added this to the V0.9 (Beta) milestone Mar 6, 2017
@ben-clayton ben-clayton self-assigned this Mar 6, 2017
@dsrbecky
Copy link
Contributor

dsrbecky commented Mar 7, 2017

+1 for the global. Do we want to introduce the concept of thread-local storage, or we just update it before each command?

UI wise: How about moving all globals to combo box?

@ben-clayton
Copy link
Contributor Author

Given that the state reflects the currently selected command, then the state should probably reflect the current thread of that command.

@ben-clayton ben-clayton modified the milestone: V0.9 (Beta) May 19, 2017
@ben-clayton ben-clayton removed their assignment Jun 14, 2017
@ben-clayton ben-clayton added P3 and removed P2 labels Aug 23, 2017
@dsrbecky
Copy link
Contributor

Do we consider this done now?

@ben-clayton
Copy link
Contributor Author

I think we should probably implement @hidden first to hide fields we shouldn't be showing.
Then it can probably be removed from the milestone. After that there's still polish I'd like to do.

@ben-clayton
Copy link
Contributor Author

Also - filter to currently selected context.

@ben-clayton ben-clayton added P2 and removed P3 labels Sep 6, 2017
@ben-clayton ben-clayton self-assigned this Sep 8, 2017
AWoloszyn pushed a commit to AWoloszyn/gapid that referenced this issue Feb 19, 2020
purvisa-at-google-com pushed a commit to purvisa-at-google-com/gapid that referenced this issue Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants