Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified commands disappear from command tree #1265

Closed
ben-clayton opened this issue Oct 25, 2017 · 2 comments
Closed

Modified commands disappear from command tree #1265

ben-clayton opened this issue Oct 25, 2017 · 2 comments
Labels
bug P2

Comments

@ben-clayton
Copy link
Contributor

Right click on a command.

screen shot 2017-10-25 at 10 22 41 pm

Modify a value, click OK...

screen shot 2017-10-25 at 10 23 43 pm

And it disappears. Magic.

The command isn't landing in another context.
Not sure if this is client side or server side. Saving and reopening the capture makes the command re-appear.
@ben-clayton ben-clayton added this to the V1.0 milestone Oct 25, 2017
@Qining
Copy link
Contributor

Qining commented Oct 26, 2017

Let me have a check if this is related to #1236

@Qining
Copy link
Contributor

Qining commented Oct 26, 2017

Confirmed not related to #1236.

ben-clayton added a commit to ben-clayton/gapid that referenced this issue Oct 30, 2017
@ben-clayton
gapis/resolve: Fix commands vanishing on edit.
fa2b837 
The caller private field was not being propagated, resulting the command being grouped under the 0'th command.

Fixes: google#1265
@ben-clayton ben-clayton mentioned this issue Oct 30, 2017
Merged
ben-clayton added a commit that referenced this issue Oct 30, 2017
@ben-clayton
gapis/resolve: Fix commands vanishing on edit.
01963d2 
The caller private field was not being propagated, resulting the command being grouped under the 0'th command.

Fixes: #1265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Qining @ben-clayton