Skip to content

Commit

Permalink
gles/compat: Ignore glInvalidateSubFramebuffer.
Browse files Browse the repository at this point in the history
Don’t remove glInvalidateFramebuffer if it is supported.
  • Loading branch information
ben-clayton committed Oct 6, 2017
1 parent 5f2f395 commit 0ec1426
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions gapis/api/gles/compat.go
Original file line number Diff line number Diff line change
Expand Up @@ -916,13 +916,17 @@ func compat(ctx context.Context, device *device.Instance) (transform.Transformer
// It has no effect on rendering so just drop it.
return

case *GlInvalidateFramebuffer,
*GlDiscardFramebufferEXT: // GL_EXT_discard_framebuffer
case *GlDiscardFramebufferEXT: // GL_EXT_discard_framebuffer
// It may not be implemented by the replay driver.
// It is only a hint so we can just drop it.
// TODO: It has performance impact so we should not ignore it when profiling.
return

case *GlInvalidateFramebuffer, *GlInvalidateSubFramebuffer:
if !version.AtLeastES(3, 0) || !version.AtLeastGL(4, 3) {
return // Not supported. Only a hint. Drop it.
}

case *GlMapBufferOES:
if !version.IsES { // Remove extension suffix on desktop.
cmd := cb.GlMapBuffer(cmd.Target, cmd.Access, memory.Pointer(cmd.Result))
Expand Down

0 comments on commit 0ec1426

Please sign in to comment.