Bringing changes in https://github.com/google/flax/pull/2955 internally. #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #2960 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 55 55
Lines 5994 5994
=======================================
Hits 4915 4915
Misses 1079 1079 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
copybara-service
bot
force-pushed
the
test_517190606
branch
from
b7a4d73 to
c82dcee
Compare
chiamp
changed the title
|
How is |
|
@cgarciae Can I help ? |
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_517190606
branch
from
c82dcee to
f0367a4
Compare
chiamp
changed the title
cgarciae
approved these changes
Apr 3, 2023
|
Hi @SauravMaheshkar thanks for making these changes! Because config files were changed, our internal tool wasn't able to integrate the PR into our internal codebase. I had to start with a copy of your PR first internally to make the change. All credit for the work still goes to you, thanks a lot! |
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_517190606
branch
2 times, most recently
from
a60ce60 to
4d08f7f
Compare
"This PR aims to minimize the number of configuration files for the project. Instead of a separate .style.yapf, mypy.ini, pytest.ini, pytype.cfg and setup.cfg, we now would have all the configurations within the pyproject.toml file leading to a overall minimal code structure. I've also updated the .pre-commit-config.yaml file with the addition of a "check-toml" hook." PiperOrigin-RevId: 521600833
copybara-service
bot
force-pushed
the
test_517190606
branch
from
4d08f7f to
509c02d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing changes in #2955 internally.
"This PR aims to minimize the number of configuration files for the project. Instead of a separate .style.yapf, mypy.ini, pytest.ini, pytype.cfg and setup.cfg, we now would have all the configurations within the pyproject.toml file leading to a overall minimal code structure. I've also updated the .pre-commit-config.yaml file with the addition of a "check-toml" hook."