Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing changes in https://github.com/google/flax/pull/2955 internally. #2960

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Mar 16, 2023

Bringing changes in #2955 internally.

"This PR aims to minimize the number of configuration files for the project. Instead of a separate .style.yapf, mypy.ini, pytest.ini, pytype.cfg and setup.cfg, we now would have all the configurations within the pyproject.toml file leading to a overall minimal code structure. I've also updated the .pre-commit-config.yaml file with the addition of a "check-toml" hook."

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #2960 (f0367a4) into main (0dde551) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2960   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files          55       55           
  Lines        5994     5994           
=======================================
  Hits         4915     4915           
  Misses       1079     1079           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chiamp chiamp changed the title Bringing changes in https://github.com/google/flax/pull/2955 internally. feat(misc): create pyproject.toml Mar 16, 2023
@cgarciae
Copy link
Collaborator

How is doctest not breaking?

@SauravMaheshkar
Copy link
Contributor

@cgarciae Can I help ?

@copybara-service copybara-service bot changed the title feat(misc): create pyproject.toml Bringing changes in https://github.com/google/flax/pull/2955 internally. Apr 3, 2023
@chiamp chiamp changed the title Bringing changes in https://github.com/google/flax/pull/2955 internally. feat(misc): create pyproject.toml Apr 3, 2023
@chiamp
Copy link
Collaborator

chiamp commented Apr 3, 2023

Hi @SauravMaheshkar thanks for making these changes! Because config files were changed, our internal tool wasn't able to integrate the PR into our internal codebase. I had to start with a copy of your PR first internally to make the change. All credit for the work still goes to you, thanks a lot!

@copybara-service copybara-service bot changed the title feat(misc): create pyproject.toml Bringing changes in https://github.com/google/flax/pull/2955 internally. Apr 3, 2023
@copybara-service copybara-service bot force-pushed the test_517190606 branch 2 times, most recently from a60ce60 to 4d08f7f Compare April 3, 2023 23:55
"This PR aims to minimize the number of configuration files for the project. Instead of a separate .style.yapf, mypy.ini, pytest.ini, pytype.cfg and setup.cfg, we now would have all the configurations within the pyproject.toml file leading to a overall minimal code structure. I've also updated the .pre-commit-config.yaml file with the addition of a "check-toml" hook."

PiperOrigin-RevId: 521600833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants