Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake build for old versions #8173

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Fix cmake build for old versions #8173

merged 2 commits into from
Nov 23, 2023

Conversation

fliiiix
Copy link
Contributor

@fliiiix fliiiix commented Nov 22, 2023

Adresses all these issues ->
#7994
#7979
#8049

Fix 7994, Fix 7979, Fix 8049

I wasn't to sure what the deal with MSVC is here even after looking into this commit 561a936

@dbaileychess maybe we should never use INTERFACE for flatsample?

@dbaileychess
Copy link
Collaborator

I needed interface to do something, but forget the reason. Going to static lib breaks other things now, so that's why this conditional is here. I would prefer a single way to do things, but didn't have the time to investigate.

@dbaileychess dbaileychess enabled auto-merge (squash) November 23, 2023 00:11
@dbaileychess dbaileychess merged commit c6f9e01 into google:master Nov 23, 2023
@fliiiix
Copy link
Contributor Author

fliiiix commented Nov 23, 2023

fair enough and at some point it probably makes sense to change the minimal required cmake version to 3.20.0 then this check can be removed again

@fliiiix fliiiix deleted the bugfix/cmake-build branch November 23, 2023 08:39
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@fliiiix @dbaileychess
Fix cmake build for old versions (google#8173)
d36f59a 
Adresses all these issues ->
google#7994
google#7979
google#8049

Fix 7994, Fix 7979, Fix 8049

Co-authored-by: Derek Bailey <[email protected]>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@fliiiix @dbaileychess
Fix cmake build for old versions (google#8173)
8be72c8 
Adresses all these issues ->
google#7994
google#7979
google#8049

Fix 7994, Fix 7979, Fix 8049

Co-authored-by: Derek Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaileychess dbaileychess dbaileychess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fliiiix @dbaileychess