-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swift] Overall Improvements #8061
[Swift] Overall Improvements #8061
Conversation
321ca90
to
7ce0499
Compare
Out traveling - will try to have a look next week! |
Otherwise, LGTM - on a separate note, I think it would be nice to consider moving to (https://github.com/ordo-one/package-benchmark) later on when we get 5.7 as the baseline supported and look at extending the set of benchmarks a bit, but will open a separate issue for that later when the baseline has moved... |
@hassila correct me if I am wrong here but should it just work? Since we can configure the benchmark package to run on only 5.7? |
Yeah, maybe you are right - but in general it's nice to have numbers that are comparable across toolchain versions too? |
Oh yeah for sure, but since benchmark package is only supporting 5.7+, we can sacrifice benchmarks on 5.5, and 5.6. So we can focus on future toolchains. I've added it to the roadmap #6467 (comment) |
7ce0499
to
5817560
Compare
db76c02
to
c4e6b37
Compare
Wrt package-benchmark I'd suggest adopting similar structure as is done here: apple/swift-certificates#125 Then no top level project dependency is needed and it's fine with 5.7+ now. |
Definitely we can use that! I guess we can start working on it on a different PR |
…g the creating aligned since its created by the library Addresses a warning on xcode 15 regarding copying a pointer without safeguards Address PR comments regarding initializing buffers with flag Adds a test case for copying unaligned buffers Formatting code
c080c55
to
eb488ea
Compare
…g the creating aligned since its created by the library (google#8061) Addresses a warning on xcode 15 regarding copying a pointer without safeguards Address PR comments regarding initializing buffers with flag Adds a test case for copying unaligned buffers Formatting code
…g the creating aligned since its created by the library (google#8061) Addresses a warning on xcode 15 regarding copying a pointer without safeguards Address PR comments regarding initializing buffers with flag Adds a test case for copying unaligned buffers Formatting code
The following PR adds the following:
Benchmarks are impressive compared to what we used to have:
Updated code:
Old code:
Unfortunately, swift package manager doesn't allow custom compiler flags so I had to use a normal if statement to resolve this. the flag is false by default so it shouldn't be an issue most of the time, however when needed users can enable it like this:
@mr-swifter @ser-0xff @hassila a quick review here would be nice!