Fix, can't set material parameters on default material instance #854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting material parameters on default material instances has no effect- i.e., the following:
This happens with both float and sampler parameters. I'm a bit surprised this hasn't been discovered yet, so maybe I'm missing something.
Also, I think the UBO usage flag for the default material instance should match explicitly-created instances (
DYNAMIC
) unless we want the semantics that the default instance's parameters aren't meant to change...