Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper for tests to expect image results. #8518

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhoff12358
Copy link
Contributor

Currently still based around using image hashes but will be improved later.

BUGS=[402474472]

@mhoff12358 mhoff12358 added the internal Issue/PR does not affect clients label Mar 11, 2025
@mhoff12358 mhoff12358 marked this pull request as draft March 11, 2025 19:45
Currently still based around using image hashes but will be improved later.

BUGS=[402474472]
@mhoff12358 mhoff12358 force-pushed the mhoff/image_expectations branch from 8304ab3 to a920126 Compare March 11, 2025 20:45
@mhoff12358
Copy link
Contributor Author

@bejado I haven't gone through and updated the style comments from the last PR for this one, and there's an error with gmock on windows, so it's still a draft. But PTAL at the actual EXPECT_IMAGE calls in test_Blit.cpp and lemme know if you have any thoughts.

I'm considering whether it's worth bundling the flushAndWait(); into ImageExpectations's destructor.

Also, how do you feel about the technically redundant {} wrapping the ImageExpectations scope given that it's at the end of the test. I tend to like it because it makes it clearer that there's an object whose destruction matters. And it means that if a test needs two you don't wind up with some in enclosed scopes and some not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant