WebGPU: enable unpacking WGSL code in filamat #8516
Draft
+235
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t pass the test due to the webgpu build failing or similar
AndyHovingh
reviewed
Mar 12, 2025
| @@ -196,6 +197,11 @@ static constexpr const char* shaderLanguageToString(ShaderLanguage shaderLanguag | |||
| return "MSL"; | |||
| case ShaderLanguage::METAL_LIBRARY: | |||
| return "Metal precompiled library"; | |||
| case ShaderLanguage::WGSL: | |||
| return "WebGPU"; | |||
| // TODO Should we add this? | |||
There was a problem hiding this comment.
We should definitely have a default case. The question is whether we should return "Unknown", as you have done, or blow up/panic/crash (fail loudly). Normally, I would opt for the later and fail loudly, as I suspect that would get caught pretty early/quickly in the process and the "Unknown" return might not fail here, but later on in an unexpected way. So, I would lean that way myself (fail loudly) (this is not a case that should ever practically happen. if it does it is a programming error/miss).
| bool printDictionaryGLSL = false; | ||
| bool printDictionaryESSL1 = false; | ||
| bool printDictionarySPIRV = false; | ||
| bool printDictionaryMetal = false; | ||
| bool printDictionaryWGSL = false; |
There was a problem hiding this comment.
Mentioned in prior meeting, but "DictionaryWGSL" may not be relevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in filamat, enable unpacking WGSL code
BUGS = [397672412]