Add helpers for backend tests (cleanup+render loops). #8505
Conversation
|
This is missing a FIXES, waiting on getting the correct bug ID. |
filament/backend/test/Lifetimes.h
Outdated
|
|
||
| // These methods can't be overloaded because of a compiler error caused by the type safe casting | ||
| // constructor needing to be resolved for each option. | ||
| void AddSwapChain(filament::backend::SwapChainHandle swapChain); |
There was a problem hiding this comment.
I had a couple optional ideas here. Maybe name all of these methods simply add, and overload based on the argument type. Would save some verbosity since the type of the handle will be easy to infer based on context. For example:
Handle<HwTexture> const srcTexture = api.createTexture(...);
cleanup.add(srcTexture);
You could also return the handle from the add method so we can do things like this:
Handle<HwTexture> const srcTexture = cleanup.add(api.createTexture(...));
There was a problem hiding this comment.
I initially wrote this as a templated add method but IIRC there was some weird templating issue. Due to all the random github delays it's been like 3 weeks since I wrote this so I don't remember what the issue was though, I'll change back to that and either it'll work or I'll remember what the problem was.
There was a problem hiding this comment.
Sounds good! We can also address these improvements in follow-up PRs.
There was a problem hiding this comment.
- Haha, I had left a comment with the issue. It was that method overloading doesn't work because there's an implicit constructor from
Handle<A>toHandle<B>if A is a base of B and that throws off the overloading.
It seems template specialization doesn't have that issue though. - Both were pretty easy changes to throw in.
mhoff12358
force-pushed
the
mhoff/cleanup_render_loop_helpers
branch
2 times, most recently
from
e2ee467 to
7f59bf6
Compare
Both for cleaning up graphics resources at the end of a test and for starting/stopping render loops. BUGS=[402472882]
mhoff12358
force-pushed
the
mhoff/cleanup_render_loop_helpers
branch
from
7f59bf6 to
f9a4b4f
Compare
Both for cleaning up graphics resources at the end of a test and for starting/stopping render loops.