Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ahb mapping util functions to map ahb usage and format to TextureUsage and TextureFormat #8491

Merged
merged 4 commits into from
Mar 7, 2025
Merged

Add ahb mapping util functions to map ahb usage and format to TextureUsage and TextureFormat #8491

merged 4 commits into from
Mar 7, 2025

Conversation

alizahlalani
Copy link
Contributor

No description provided.

@alizahlalani alizahlalani mentioned this pull request Mar 5, 2025
Merged
@alizahlalani alizahlalani changed the title Add ahb mapping util functions to map ahb usage and format to TextureUsage and TextureFormat, resepctively Add ahb mapping util functions to map ahb usage and format to TextureUsage and TextureFormat Mar 5, 2025
poweifeng
poweifeng approved these changes Mar 5, 2025
View reviewed changes
@poweifeng poweifeng requested a review from pixelflinger March 5, 2025 06:47
pixelflinger
pixelflinger requested changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@pixelflinger pixelflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to move all the android specific code in a new BackendUtilsAndroid.h, or even better, if possible, just have this somewhere in Platform? Why can't it be in PlatformEGLAndroid?

@alizahlalani alizahlalani force-pushed the filamentUtils branch 4 times, most recently from 5ab5e70 to e405d0a Compare March 5, 2025 18:24
@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Mar 7, 2025
@poweifeng poweifeng enabled auto-merge (squash) March 7, 2025 22:13
@poweifeng poweifeng merged commit ee68872 into google:main Mar 7, 2025
10 checks passed
@alizahlalani alizahlalani deleted the filamentUtils branch March 10, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poweifeng poweifeng poweifeng approved these changes

@pixelflinger pixelflinger pixelflinger approved these changes

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alizahlalani @pixelflinger @poweifeng