Initial tint transpilation support for WebGPU #8477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyHovingh
reviewed
Feb 27, 2025
kpiascik
reviewed
Feb 28, 2025
bridgewaterrobbie
force-pushed
the
rbridgewater/filimatWgsl
branch
from
911dc1c to
1d221f1
Compare
bridgewaterrobbie
force-pushed
the
rbridgewater/filimatWgsl
branch
from
fb31a9f to
3e568a6
Compare
sidreesshah
force-pushed
the
idris/webgpu_backend
branch
6 times, most recently
from
dda56ab to
ffdece2
Compare
bridgewaterrobbie
force-pushed
the
rbridgewater/filimatWgsl
branch
from
3e568a6 to
b29a2a3
Compare
AndyHovingh
reviewed
Mar 5, 2025
| *outWsl = wgslOut->wgsl; | ||
| return true; | ||
| #else | ||
| slog.i << "Trying to emit WGSL without including WebGPU dependencies, please set CMake arg FILAMENT_SUPPORTS_WEBGPU and TINT_BUILD_SPV_READER" << io::endl; |
There was a problem hiding this comment.
should this be a warning, e.g. slog.w?
There was a problem hiding this comment.
Hrm. A bit debatable, but either way functionally it will fail out due to the return false below it. It could also arguably be slog.e.
I'd like to leave it at the moment unless others clarify the common patterns expected in filament.
jc3265
reviewed
Mar 5, 2025
poweifeng
reviewed
Mar 6, 2025
bridgewaterrobbie
force-pushed
the
rbridgewater/filimatWgsl
branch
2 times, most recently
from
06d426e to
1b09245
Compare
poweifeng
approved these changes
Mar 6, 2025
Early version that will allow errors to be ignored currently, outputting what we can into filamat results.
bridgewaterrobbie
force-pushed
the
rbridgewater/filimatWgsl
branch
from
1b09245 to
a3f0d0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGS = [398273927]