Fix issue where material instance name cannot be set without creating a default instance #8213
Conversation
… a default instance
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@kunyoungparkk would you be able to sign the CLA so we can merge this change? Thank you! |
filament/src/details/Engine.cpp
Outdated
| FMaterialInstance* p = mHeapAllocator.make<FMaterialInstance>(*this, material); | ||
| FMaterialInstance* FEngine::createMaterialInstance(const FMaterial* material, | ||
| const char* name) noexcept { | ||
| FMaterialInstance* p = |
There was a problem hiding this comment.
Fixed spacing as suggested. Thanks for pointing that out!
| @@ -53,7 +53,8 @@ class FTexture; | |||
|
|
|||
| class FMaterialInstance : public MaterialInstance { | |||
| public: | |||
| FMaterialInstance(FEngine& engine, FMaterial const* material) noexcept; | |||
| FMaterialInstance(FEngine& engine, FMaterial const* material, | |||
There was a problem hiding this comment.
Fixed spacing as suggested. Thanks for pointing that out!
|
@kunyoungparkk windows build is failing |
I’m currently investigating the issue as the build is working fine in my local Windows environment. It might take some time to identify the root cause. I appreciate your patience, and I will provide an update once the issue is resolved. |
This PR is related to PR #8147
After applying PR #8147, FMaterial::createInstance has an issue where it ignores the name passed as a parameter when mDefaultMaterialInstance is not set.
By applying this PR, a material instance can be assigned a name even if mDefaultMaterialInstance is not set.