Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public API in View for transparent picking #8206

Merged
merged 13 commits into from
Oct 22, 2024

Conversation

show50726
Copy link
Contributor

@show50726 show50726 marked this pull request as ready for review October 17, 2024 12:15
@show50726 show50726 force-pushed the dev/transparent-picking-api branch from f12d701 to ef1e217 Compare October 17, 2024 12:16
@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Oct 17, 2024
Copy link
Collaborator

@pixelflinger pixelflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the Java APIs as well as the Javascript ones (in js-bindings.cpp)

@show50726 show50726 closed this Oct 18, 2024
@show50726 show50726 reopened this Oct 18, 2024
@show50726
Copy link
Contributor Author

You also need to add the Java APIs as well as the Javascript ones (in js-bindings.cpp)

Done. I didn't notice that, thanks for the reminder:D

BTW, I noticed that there are some functions in View are not added to jsbindings.cpp (ex. View::setFrontFaceWindingInverted).
I'm wondering if that is on purpose? or some functions are missed and it would need a PR to fix them? Thanks!

@olenev
Copy link

olenev commented Oct 21, 2024

Thank you for this pull request.
Awaiting for this feature also.

@pixelflinger pixelflinger merged commit 17e4d2b into google:main Oct 22, 2024
1 check passed
@pixelflinger
Copy link
Collaborator

You also need to add the Java APIs as well as the Javascript ones (in js-bindings.cpp)

Done. I didn't notice that, thanks for the reminder:D

BTW, I noticed that there are some functions in View are not added to jsbindings.cpp (ex. View::setFrontFaceWindingInverted). I'm wondering if that is on purpose? or some functions are missed and it would need a PR to fix them? Thanks!

yes I think we are missing a lot of stuff. unfortunately this process is manual and we have missed some in the past.

@olenev
Copy link

olenev commented Oct 23, 2024

@show50726 could you please check that by default transparent materials not picking?
Because I test it on my model with transparent materials and if I set setTransparentPickingEnabled(boolean enabled) to false or event don't set it all, I am still able to select it.

@show50726
Copy link
Contributor Author

@show50726 could you please check that by default transparent materials not picking? Because I test it on my model with transparent materials and if I set setTransparentPickingEnabled(boolean enabled) to false or event don't set it all, I am still able to select it.

Hello @olenev,
Could you provide which platform you are working on, and how do you configure material, or even better, a public branch where I can try it directly?

I tried it before making this PR and I did not see this problem, so I’d like to know about your configuration.
Thanks!

@olenev
Copy link

olenev commented Oct 23, 2024

Could you provide which platform you are working on, and how do you configure material, or even better, a public branch where I can try it directly?

@show50726 thank you. I using filament on Android project (Java, Kotlin). I will try to prepare test project tomorrow with part of my model to reproduce this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picking transparent renderables
3 participants