-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public API in View for transparent picking #8206
Add public API in View for transparent picking #8206
Conversation
Fix the texture format Decide texture format based on feature level
f12d701
to
ef1e217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add the Java APIs as well as the Javascript ones (in js-bindings.cpp)
Done. I didn't notice that, thanks for the reminder:D BTW, I noticed that there are some functions in |
Thank you for this pull request. |
yes I think we are missing a lot of stuff. unfortunately this process is manual and we have missed some in the past. |
@show50726 could you please check that by default transparent materials not picking? |
Hello @olenev, I tried it before making this PR and I did not see this problem, so I’d like to know about your configuration. |
@show50726 thank you. I using filament on Android project (Java, Kotlin). I will try to prepare test project tomorrow with part of my model to reproduce this issue. |
Blocked by #8190
Close #6614
This change is tested in https://github.com/show50726/filament/tree/dev/picking-test-env