Add warning for the incompatibility of stereo type #8031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print a warning in case the sterescopic type in a compiled package is different than what's in the engine's setting. The application may proceed, but it could end up visual glitches when enabling stereoscopic rendering. This requires the stereoscopic type to be written into the package, which needs a material version bump.
pixelflinger
approved these changes
Aug 10, 2024
poweifeng
reviewed
Aug 12, 2024
| if (materialDomain == MaterialDomain::SURFACE) { | ||
| StereoscopicType const engineStereoscopicType = engine.getConfig().stereoscopicType; | ||
| StereoscopicType materialStereoscopicType = StereoscopicType::NONE; | ||
| materialParser->getStereoscopicType(&materialStereoscopicType); |
There was a problem hiding this comment.
Does the bool returned here indicate whether getting the chunk was successful or not? Should we only do the following conditional only if the chunk was successfully parsed?
I think this'll happen if the material is of an older version than filament.
There was a problem hiding this comment.
Yeah I also realized it returns a boolean but found other usages don't check that either. Maybe it'd be nice to handle them together later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a warning in case the stereoscopic type in a compiled package is different than what's in the engine's setting. The application may proceed, but it could end up visual glitches when enabling stereoscopic rendering.
This requires the stereoscopic type to be written into the package, which needs a material version bump.