Fix a crash for IBL resource loading #8001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bejado
approved these changes
Jul 29, 2024
z3moon
force-pushed
the
zm/fix-timerinfo-crash-main
branch
from
de42f11 to
4462619
Compare
pixelflinger
approved these changes
Jul 29, 2024
This fixes a crash introduced by a8ace28 The refactored FrameInfoManager is now required to be called properly within the renderStandaloneView method, which is mainly being called by IBLPrefilterContext. Also fix a null pointer reference bug for OpenGLTimer::State, which happenes when the renderer for IBLPrefilterContext is destroyed.
Co-authored-by: Mathias Agopian <[email protected]>
Co-authored-by: Mathias Agopian <[email protected]>
z3moon
force-pushed
the
zm/fix-timerinfo-crash-main
branch
from
6af2794 to
73ed9e1
Compare
z3moon
added a commit
that referenced
this pull request
Jul 29, 2024
This fixes a crash introduced by a8ace28 The refactored FrameInfoManager can cause a crash when IBL resource loading happens because now the getLastFrameInfo() references an invalid value via the `front` method. Return the default FrameInfo to resolve this. Also fix a null pointer reference bug for OpenGLTimer::State, which happenes when the renderer for IBLPrefilterContext is destroyed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash introduced by a8ace28
The refactored FrameInfoManager is now required to be called properly within the renderStandaloneView method, which is mainly being called by IBLPrefilterContext.
Also fix a null pointer reference bug for OpenGLTimer::State, which happenes when the renderer for IBLPrefilterContext is destroyed.