Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build failures due to filamat lite removal #2 #7224

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix build failures due to filamat lite removal #2 #7224

merged 1 commit into from
Oct 3, 2023

Conversation

poweifeng
Copy link
Contributor

No description provided.

@poweifeng poweifeng added the internal Issue/PR does not affect clients label Oct 3, 2023
bejado
bejado approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@bejado bejado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize we also got rid of gltfio full/lite, thanks!

@poweifeng poweifeng merged commit b4d6f97 into main Oct 3, 2023
@poweifeng poweifeng deleted the pf/fix-broken-build-gltfio-full branch October 3, 2023 19:39
plepers pushed a commit to plepers/filament that referenced this pull request Dec 9, 2023
@poweifeng @plepers
Fix build failures due to filamat lite removal google#2 (google#7224)
07e2b3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bejado bejado bejado approved these changes

@romainguy romainguy Awaiting requested review from romainguy

@pixelflinger pixelflinger Awaiting requested review from pixelflinger

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poweifeng @bejado