Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pathing issues on Windows #49

Merged
merged 5 commits into from
Aug 8, 2018
Merged

Fix pathing issues on Windows #49

merged 5 commits into from
Aug 8, 2018

Conversation

bejado
Copy link
Member

@bejado bejado commented Aug 8, 2018

Fix Path::split, Path::isAbsolute, Path::getParent, and getCanonicalPath on Windows.

Fixes #13
Fixes #14

Some edge-case windows pathing may still not work:

  • "drive relative" paths: "C:tmp.txt"
  • UNC paths (network paths): "\foo\bar" (will be collapsed to \foo\bar, which may resolve to a different location than expected)
  • "absolute paths": "\foo\bar" (may or may not resolve to drive root)

@@ -1,74 +1,70 @@
/*
Copy link
Member Author

@bejado bejado Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed line endings to UNIX style, hence the massive diff. New function at the very bottom: Path::isAbsolute

@bejado bejado merged commit 520ff90 into master Aug 8, 2018
@bejado bejado deleted the bjd/fix-win-paths branch August 8, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants